Bug 192914 - Fix test262 expectations
Summary: Fix test262 expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-19 20:57 PST by Keith Miller
Modified: 2018-12-19 22:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (46.75 KB, patch)
2018-12-19 20:58 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-12-19 20:57:08 PST 
Fix test262 expectations
Comment 1 Keith Miller 2018-12-19 20:58:13 PST 
Created attachment 357773 [details]
Patch
Comment 2 Keith Miller 2018-12-19 21:00:45 PST 
Committed r239429: <https://trac.webkit.org/changeset/239429>
Comment 3 Radar WebKit Bug Importer 2018-12-19 21:01:27 PST 
<rdar://problem/46862230>
Comment 4 Ross Kirsling 2018-12-19 22:24:57 PST 
Somehow there were still 20 missing, so I added them in r239431: <https://trac.webkit.org/changeset/239431>
Comment 5 Keith Miller 2018-12-19 22:33:05 PST 
(In reply to Ross Kirsling from comment #4)
> Somehow there were still 20 missing, so I added them in r239431:
> <https://trac.webkit.org/changeset/239431>

I think those are methods guarded by an ICU version #if. We should probably skip them instead for now. The test262 runner script isn't smart enough to know how to check that ...