Bug 192869 - Remove RTCRtpTransceiver.setDirection
Summary: Remove RTCRtpTransceiver.setDirection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-19 12:06 PST by youenn fablet
Modified: 2018-12-19 14:01 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2018-12-19 12:09 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-12-19 12:06:12 PST 
The attribute setter deprecates this method.
Comment 1 youenn fablet 2018-12-19 12:09:30 PST 
Created attachment 357707 [details]
Patch
Comment 2 Alex Christensen 2018-12-19 12:56:28 PST 
Comment on attachment 357707 [details]
Patch

Can't we remove the C++ function, too?
Comment 3 youenn fablet 2018-12-19 13:33:40 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 357707 [details]
> Patch
> 
> Can't we remove the C++ function, too?

The C++ function is used when setting the 'direction' attribute.
Comment 4 WebKit Commit Bot 2018-12-19 14:00:32 PST 
Comment on attachment 357707 [details]
Patch

Clearing flags on attachment: 357707

Committed r239391: <https://trac.webkit.org/changeset/239391>
Comment 5 WebKit Commit Bot 2018-12-19 14:00:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-19 14:01:33 PST 
<rdar://problem/46851629>