Bug 192804 - Some iOS app crash in FrameLoader::checkCompleted
Summary: Some iOS app crash in FrameLoader::checkCompleted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-17 22:14 PST by Ryosuke Niwa
Modified: 2018-12-18 14:04 PST (History)
10 users (show)

See Also:

Attachments
Fix attempt (3.99 KB, patch)
2018-12-17 22:17 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed builds and incorporated Tim's comment (4.04 KB, patch)
2018-12-18 12:02 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-12-17 22:14:02 PST 
Some iOS app crash in FrameLoader::checkCompleted
Comment 1 Ryosuke Niwa 2018-12-17 22:17:12 PST 
Created attachment 357536 [details]
Fix attempt
Comment 2 Tim Horton 2018-12-17 23:28:19 PST 
Comment on attachment 357536 [details]
Fix attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=357536&action=review

> Source/WebCore/dom/ScriptDisallowedScope.h:90
> +#if TARGET_OS_IPHONE

Why not PLATFORM(IOS_FAMILY)?
Comment 3 Ryosuke Niwa 2018-12-18 11:48:48 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 357536 [details]
> Fix attempt
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357536&action=review
> 
> > Source/WebCore/dom/ScriptDisallowedScope.h:90
> > +#if TARGET_OS_IPHONE
> 
> Why not PLATFORM(IOS_FAMILY)?

Good point. Will fix.
Comment 4 Ryosuke Niwa 2018-12-18 12:02:25 PST 
Created attachment 357594 [details]
Fixed builds and incorporated Tim's comment
Comment 5 Ryosuke Niwa 2018-12-18 14:03:09 PST 
Comment on attachment 357594 [details]
Fixed builds and incorporated Tim's comment

Clearing flags on attachment: 357594

Committed r239353: <https://trac.webkit.org/changeset/239353>
Comment 6 Ryosuke Niwa 2018-12-18 14:03:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-18 14:04:26 PST 
<rdar://problem/46821178>