WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 192764
Web Inspector: Audit: fix descriptions for default tests
https://bugs.webkit.org/show_bug.cgi?id=192764
Summary
Web Inspector: Audit: fix descriptions for default tests
Devin Rousso
Reported
2018-12-17 11:02:36 PST
.
Attachments
Patch
(15.63 KB, patch)
2018-12-17 11:04 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(14.72 KB, patch)
2018-12-19 22:21 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2018-12-17 11:03:13 PST
<
rdar://problem/46729437
>
Devin Rousso
Comment 2
2018-12-17 11:04:37 PST
Created
attachment 357454
[details]
Patch
Matt Baker
Comment 3
2018-12-19 20:11:23 PST
Comment on
attachment 357454
[details]
Patch rs=me
WebKit Commit Bot
Comment 4
2018-12-19 20:13:44 PST
Comment hidden (obsolete)
Comment on
attachment 357454
[details]
Patch Rejecting
attachment 357454
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 357454, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=357454&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=192764
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 357454 from
bug 192764
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=357454
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Matt Baker']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 FAILED at 53. Hunk #2 FAILED at 122. Hunk #3 succeeded at 368 (offset 4 lines). Hunk #4 succeeded at 947 (offset 5 lines). 2 out of 4 hunks FAILED -- saving rejects to file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js.rej patching file Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Matt Baker']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
https://webkit-queues.webkit.org/results/10484925
Matt Baker
Comment 5
2018-12-19 20:36:07 PST
Needs to be rebased.
Devin Rousso
Comment 6
2018-12-19 22:21:16 PST
Created
attachment 357782
[details]
Patch
WebKit Commit Bot
Comment 7
2018-12-19 22:48:40 PST
Comment on
attachment 357782
[details]
Patch Clearing flags on attachment: 357782 Committed
r239433
: <
https://trac.webkit.org/changeset/239433
>
WebKit Commit Bot
Comment 8
2018-12-19 22:48:41 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug