Bug 192716 - kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
Summary: kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-14 13:34 PST by youenn fablet
Modified: 2018-12-14 16:07 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.32 KB, patch)
2018-12-14 13:36 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.80 MB, application/zip)
2018-12-14 15:33 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-12-14 13:34:05 PST
kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
Comment 1 youenn fablet 2018-12-14 13:36:41 PST
Created attachment 357337 [details]
Patch
Comment 2 EWS Watchlist 2018-12-14 15:33:47 PST
Comment on attachment 357337 [details]
Patch

Attachment 357337 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10402560

New failing tests:
webanimations/leak-document-with-web-animation.html
Comment 3 EWS Watchlist 2018-12-14 15:33:59 PST
Created attachment 357348 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 youenn fablet 2018-12-14 15:40:28 PST
Comment on attachment 357337 [details]
Patch

win error is unrelated
Comment 5 WebKit Commit Bot 2018-12-14 16:06:24 PST
Comment on attachment 357337 [details]
Patch

Clearing flags on attachment: 357337

Committed r239240: <https://trac.webkit.org/changeset/239240>
Comment 6 WebKit Commit Bot 2018-12-14 16:06:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-14 16:07:39 PST
<rdar://problem/46745341>