Bug 192690 - Remove a global 'using namespace WebKit' in WebViewImpl.mm
Summary: Remove a global 'using namespace WebKit' in WebViewImpl.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-13 19:47 PST by David Quesada
Modified: 2018-12-14 10:15 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.20 KB, patch)
2018-12-13 19:50 PST, David Quesada 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2018-12-13 19:47:29 PST 
I didn't see this covered by the other patches working on this now. An unrelated patch I ran through EWS shuffled the unified builds such that this using statement caused build failures, and I came up with the fix.
Comment 1 David Quesada 2018-12-13 19:50:16 PST 
Created attachment 357290 [details]
Patch
Comment 2 WebKit Commit Bot 2018-12-14 10:14:40 PST 
Comment on attachment 357290 [details]
Patch

Clearing flags on attachment: 357290

Committed r239218: <https://trac.webkit.org/changeset/239218>
Comment 3 WebKit Commit Bot 2018-12-14 10:14:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-14 10:15:26 PST 
<rdar://problem/46733680>