Bug 192618 – [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Fujii Hironori]

[Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

clang-cl reports the following compilation warnings:

> ..\..\Source\WebKitLegacy\win\WebCoreSupport\WebInspectorDelegate.cpp(60,9):  warning: delete called on non-final 'WebInspectorDelegate' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebCoreSupport\WebEditorClient.cpp(115,9):  warning: delete called on non-final 'WebEditorUndoTarget' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebCoreSupport\WebEditorClient.cpp(568,9):  warning: delete called on non-final 'WebEditorUndoCommand' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\COMPropertyBag.h(127,9):  warning: delete called on non-final 'COMPropertyBag<WTF::String, WTF::String, WTF::StringHash>' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\COMPropertyBag.h(127,9):  warning: delete called on non-final 'COMPropertyBag<COMVariant, WTF::String, WTF::StringHash>' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\CFDictionaryPropertyBag.cpp(90,9):  warning: delete called on non-final 'CFDictionaryPropertyBag' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\DefaultPolicyDelegate.cpp(97,9):  warning: delete called on non-final 'DefaultPolicyDelegate' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\DefaultDownloadDelegate.cpp(102,9):  warning: delete called on non-final 'DefaultDownloadDelegate' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\MemoryStream.cpp(81,9):  warning: delete called on non-final 'MemoryStream' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebCache.cpp(93,9):  warning: delete called on non-final 'WebCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebArchive.cpp(90,9):  warning: delete called on non-final 'WebArchive' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebApplicationCache.cpp(114,9):  warning: delete called on non-final 'WebApplicationCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebError.cpp(101,9):  warning: delete called on non-final 'WebError' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebDataSource.cpp(157,9):  warning: delete called on non-final 'WebDataSource' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebDatabaseManager.cpp(100,9):  warning: delete called on non-final 'DatabaseDetailsPropertyBag' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebBackForwardList.cpp(111,9):  warning: delete called on non-final 'WebBackForwardList' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebFramePolicyListener.cpp(87,9):  warning: delete called on non-final 'WebFramePolicyListener' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebDownload.cpp(121,9):  warning: delete called on non-final 'WebDownload' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebGeolocationPosition.cpp(77,9):  warning: delete called on non-final 'WebGeolocationPosition' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebActionPropertyBag.cpp(91,9):  warning: delete called on non-final 'WebActionPropertyBag' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebElementPropertyBag.cpp(93,9):  warning: delete called on non-final 'WebElementPropertyBag' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebGeolocationPolicyListener.cpp(81,9):  warning: delete called on non-final 'WebGeolocationPolicyListener' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebDropSource.cpp(90,9):  warning: delete called on non-final 'WebDropSource' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebKitStatistics.cpp(92,9):  warning: delete called on non-final 'WebKitStatistics' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebHistory.cpp(232,9):  warning: delete called on non-final 'WebHistory' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebKitMessageLoop.cpp(80,9):  warning: delete called on non-final 'WebKitMessageLoop' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebHistoryItem.cpp(401,9):  warning: delete called on non-final 'WebHistoryItem' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebNotification.cpp(96,9):  warning: delete called on non-final 'WebNotification' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebHTMLRepresentation.cpp(98,9):  warning: delete called on non-final 'WebHTMLRepresentation' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebNotificationCenter.cpp(102,9):  warning: delete called on non-final 'WebNotificationCenter' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebJavaScriptCollector.cpp(88,9):  warning: delete called on non-final 'WebJavaScriptCollector' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebNavigationData.cpp(58,9):  warning: delete called on non-final 'WebNavigationData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebKitClassFactory.cpp(105,9):  warning: delete called on non-final 'WebKitClassFactory' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebInspector.cpp(101,9):  warning: delete called on non-final 'WebInspector' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebSecurityOrigin.cpp(91,9):  warning: delete called on non-final 'WebSecurityOrigin' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebTextRenderer.cpp(75,9):  warning: delete called on non-final 'WebTextRenderer' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebMutableURLRequest.cpp(135,9):  warning: delete called on non-final 'WebMutableURLRequest' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebSerializedJSValue.cpp(58,9):  warning: delete called on non-final 'WebSerializedJSValue' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebCoreStatistics.cpp(94,9):  warning: delete called on non-final 'WebCoreStatistics' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebResource.cpp(90,9):  warning: delete called on non-final 'WebResource' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebPreferences.cpp(600,9):  warning: delete called on non-final 'WebPreferences' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebURLCredential.cpp(92,9):  warning: delete called on non-final 'WebURLCredential' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebURLAuthenticationChallenge.cpp(102,9):  warning: delete called on non-final 'WebURLAuthenticationChallenge' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebURLProtectionSpace.cpp(92,9):  warning: delete called on non-final 'WebURLProtectionSpace' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebUserContentURLPattern.cpp(61,9):  warning: delete called on non-final 'WebUserContentURLPattern' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebURLAuthenticationChallengeSender.cpp(90,9):  warning: delete called on non-final 'WebURLAuthenticationChallengeSender' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebWorkersPrivate.cpp(65,9):  warning: delete called on non-final 'WebWorkersPrivate' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebScriptWorld.cpp(98,9):  warning: delete called on non-final 'WebScriptWorld' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebURLResponse.cpp(281,9):  warning: delete called on non-final 'WebURLResponse' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebFrame.cpp(405,9):  warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebFrame.cpp(790,13):  warning: delete called on non-final 'EnumChildFrames' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\COMPropertyBag.h(127,9):  warning: delete called on non-final 'COMPropertyBag<COMVariant, WTF::String, WTF::StringHash>' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
> ..\..\Source\WebKitLegacy\win\WebView.cpp(7417,13):  warning: delete called on non-final 'EnumTextMatches' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]

[Fujii Hironori]

Created attachment 357113 [details]
Patch

[Fujii Hironori]

Comment on attachment 357113 [details]
Patch

Clearing flags on attachment: 357113

Committed r239151: <https://trac.webkit.org/changeset/239151>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46688189>