Bug 192609 - Web Inspector: Canvas: support recording TypedOMCSSImageValue
Summary: Web Inspector: Canvas: support recording TypedOMCSSImageValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 190217
Blocks:
  Show dependency tree / graph
 
Reported: 2018-12-11 19:33 PST by Justin Michaud
Modified: 2019-04-23 13:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.65 KB, patch)
2019-04-19 08:27 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2019-04-19 11:54 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-12-11 19:33:11 PST 
There is a TODO in InspectorCanvas.cpp, to implement buildAction for TypedOMCSSImageValue. It is (as of the time of this bug) located on line 624.
Comment 1 Devin Rousso 2019-04-19 08:27:44 PDT 
Created attachment 367799 [details]
Patch
Comment 2 Devin Rousso 2019-04-19 11:54:58 PDT 
Created attachment 367810 [details]
Patch
Comment 3 Justin Michaud 2019-04-19 13:33:56 PDT 
Sweet
Comment 4 WebKit Commit Bot 2019-04-23 13:32:45 PDT 
Comment on attachment 367810 [details]
Patch

Clearing flags on attachment: 367810

Committed r244562: <https://trac.webkit.org/changeset/244562>
Comment 5 WebKit Commit Bot 2019-04-23 13:32:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-04-23 13:33:20 PDT 
<rdar://problem/50142011>