Bug 192242 – [PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

We are sometimes swapping processes even though there is an opened window with an opener link to us, which is not Web-compatible.

[Chris Dumez]

Created attachment 356230 [details]
Patch

[EWS Watchlist]

Attachment 356230 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:346:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:348:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:352:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 356230 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 356230 [details]
Patch

Clearing flags on attachment: 356230

Committed r238755: <https://trac.webkit.org/changeset/238755>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46384268>