Bug 192167 - Fix Build for old MacOS versions
Summary: Fix Build for old MacOS versions
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
Depends on:
Reported: 2018-11-29 11:19 PST by Megan Gardner
Modified: 2021-11-01 14:41 PDT (History)
4 users (show)

See Also:

Patch (1.46 KB, patch)
2018-11-29 11:21 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2018-11-29 13:01 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-11-29 11:19:01 PST
Fix Build for old MacOS versions
Comment 1 Megan Gardner 2018-11-29 11:21:24 PST
Created attachment 356026 [details]
Comment 2 WebKit Commit Bot 2018-11-29 12:43:47 PST
Comment on attachment 356026 [details]

Rejecting attachment 356026 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 356026, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=356026&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192167&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 356026 from bug 192167.
Fetching: https://bugs.webkit.org/attachment.cgi?id=356026
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
|Index: Source/WebCore/editing/cocoa/DictionaryLookup.mm
|index 445d2efd9849c43db5526d7ad6d3c47d19348776..0ea2b43536cc8b2b0ec0356e8a471bb415a7088e 100644
|--- Source/WebCore/editing/cocoa/DictionaryLookup.mm	(revision 0)
|+++ Source/WebCore/editing/cocoa/DictionaryLookup.mm	(working copy)
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10201424
Comment 3 Megan Gardner 2018-11-29 13:01:44 PST
Created attachment 356038 [details]
Comment 4 Alexey Proskuryakov 2018-11-29 14:03:42 PST
The coat has still does not apply.
Comment 5 Alex Christensen 2021-11-01 12:45:20 PDT
Comment on attachment 356038 [details]

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.