Bug 192111 - SQLiteDatabase::open is constantly printing "SQLite database failed to checkpoint: database table is locked" errors
Summary: SQLiteDatabase::open is constantly printing "SQLite database failed to checkp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-28 15:17 PST by Christopher Reid
Modified: 2018-11-28 17:41 PST (History)
7 users (show)

See Also:


Attachments
patch (2.98 KB, patch)
2018-11-28 15:20 PST, Christopher Reid
no flags Details | Formatted Diff | Diff
Fixing indents (2.95 KB, patch)
2018-11-28 15:26 PST, Christopher Reid
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2018-11-28 15:17:12 PST
See https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/686/steps/layout-test/logs/stdio. There's over 2000 instances of these errors consistent across all platforms.
Comment 1 Christopher Reid 2018-11-28 15:20:57 PST
Created attachment 355925 [details]
patch
Comment 2 EWS Watchlist 2018-11-28 15:23:40 PST
Attachment 355925 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/sql/SQLiteDatabase.cpp:118:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/sql/SQLiteDatabase.cpp:119:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/sql/SQLiteDatabase.cpp:122:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Christopher Reid 2018-11-28 15:26:15 PST
Created attachment 355928 [details]
Fixing indents
Comment 4 WebKit Commit Bot 2018-11-28 17:39:28 PST
Comment on attachment 355928 [details]
Fixing indents

Clearing flags on attachment: 355928

Committed r238652: <https://trac.webkit.org/changeset/238652>
Comment 5 WebKit Commit Bot 2018-11-28 17:39:29 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-28 17:41:19 PST
<rdar://problem/46328240>