Bug 192062 - Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
Summary: Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-27 18:13 PST by Alex Christensen
Modified: 2018-11-28 13:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (39.51 KB, patch)
2018-11-27 18:14 PST, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-11-27 18:13:37 PST 
Add SessionIDs wherever BlobURLs are used in SerializedScriptValue
Comment 1 Alex Christensen 2018-11-27 18:14:40 PST 
Created attachment 355833 [details]
Patch
Comment 2 EWS Watchlist 2018-11-27 18:19:07 PST 
Attachment 355833 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:587:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:1838:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/SerializedScriptValue.cpp:3278:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2018-11-28 09:35:14 PST 
Comment on attachment 355833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355833&action=review

> Source/WebCore/ChangeLog:8
> +        Just adding infrastructure for fixing "the blob bug"

Should be "the blog blug"
Comment 4 Alex Christensen 2018-11-28 13:11:34 PST 
http://trac.webkit.org/r238632
Comment 5 Radar WebKit Bug Importer 2018-11-28 13:12:42 PST 
<rdar://problem/46319290>