webkit.org/b/190738 media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html [ Timeout ] webkit.org/b/190738 media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html [ Timeout ] As bug 190738 is resolved, these tests are now pass.
Created attachment 355726 [details] Patch
Comment on attachment 355726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355726&action=review Thanks Yacine! Just a small issue with the DRT output in this patch, but the rest LGTM. We'll need to wait for a formal review before landing though :) > LayoutTests/platform/gtk/TestExpectations:-1212 > -webkit.org/b/190738 imported/w3c/web-platform-tests/encrypted-media/resources/clearkey-retrieve-persistent-license.html [ Missing ] Please keep these two [ Missing ] expectations, they are not tests, but rather helper files, and including them introduces the DRT output you have included in this patch. > LayoutTests/platform/gtk/imported/w3c/web-platform-tests/encrypted-media/resources/clearkey-retrieve-destroy-persistent-license-expected.txt:1 > +layer at (0,0) size 800x600 All these DRT outputs can be removed, (see above)
Created attachment 355744 [details] Patch
Perfect, thanks again. Informal r+ from me.
Comment on attachment 355744 [details] Patch Attachment 355744 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10169132 New failing tests: media/no-fullscreen-when-hidden.html
Created attachment 355756 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 355744 [details] Patch Are there no changes in the WPE expectations?
(In reply to Xabier Rodríguez Calvar from comment #7) > Comment on attachment 355744 [details] > Patch > > Are there no changes in the WPE expectations? Currently I think no.
Not sure why this stalled, but it's out of date now.