Bug 191766 – Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key

• Status: REOPENED
• Component: Web Inspector

[Matt Baker]

Summary:
TreeOutline shouldn't select first child of an expanded element on right arrow key.

Steps to Reproduce:
1. Select a tree element with at least one child
2. Expand the tree element
3. Press Right Arrow key
  => Selection moves to first child. In Finder and Xcode, the selection does not change.

We should continue to do the following behaviors, which match the system:

- Pressing the Left Arrow key when the first child of an expanded item is selected moves the selection up to the parent
- Pressing the Right Arrow key when an item is collapsed expands the item

[Matt Baker]

Created attachment 355104 [details]
Patch

[Devin Rousso]

Comment on attachment 355104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355104&action=review

rs=me

Should we do anything special if the folder is already expanded? It seems like in that case we’d effectively be doing nothing. I suppose I’d that’s what the system does then it’s better to match 🤔

> Source/WebInspectorUI/ChangeLog:10
> +        Match system behavior.

This comment isn’t descriptive. Either remove it or make it more explanatory.

[Matt Baker]

Created attachment 355117 [details]
Patch for landing

[Matt Baker]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 355104 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355104&action=review
> 
> rs=me
> 
> Should we do anything special if the folder is already expanded? It seems
> like in that case we’d effectively be doing nothing. I suppose I’d that’s
> what the system does then it’s better to match 🤔

Doing nothing on Right Arrow when the selected item is expanded is precisely the system behavior being followed. It's curious that the opposite - selecting the parent on Left Arrow when the first child is selected - is the system behavior. 🤔

[WebKit Commit Bot]

Comment on attachment 355117 [details]
Patch for landing

Clearing flags on attachment: 355117

Committed r238305: <https://trac.webkit.org/changeset/238305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46140393>

[Radar WebKit Bug Importer]

<rdar://problem/46140392>

[Devin Rousso]

This was undone by r238599 <https://webkit.org/b/191483>.