Bug 191612 - Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
Summary: Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 17:00 PST by Joseph Pecoraro
Modified: 2018-11-14 15:57 PST (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (Depends on bug 191494) (32.55 KB, patch)
2018-11-13 17:01 PST, Joseph Pecoraro 		mattbaker: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (32.52 KB, patch)
2018-11-14 13:06 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Bots (34.09 KB, patch)
2018-11-14 13:32 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Bots (35.49 KB, patch)
2018-11-14 14:03 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-11-13 17:00:07 PST 
Pass Inspector::FrontendChannel as a reference connect/disconnect methods
Comment 1 Joseph Pecoraro 2018-11-13 17:01:13 PST 
Created attachment 354731 [details]
[PATCH] Proposed Fix (Depends on bug 191494)

Depends on bug 191494.
Comment 2 Matt Baker 2018-11-14 12:06:39 PST 
Comment on attachment 354731 [details]
[PATCH] Proposed Fix (Depends on bug 191494)

r=me, nice cleanup
Comment 3 Joseph Pecoraro 2018-11-14 13:06:46 PST 
Created attachment 354844 [details]
[PATCH] For Bots
Comment 4 Joseph Pecoraro 2018-11-14 13:32:17 PST 
Created attachment 354846 [details]
[PATCH] For Bots
Comment 5 Joseph Pecoraro 2018-11-14 14:03:07 PST 
Created attachment 354850 [details]
[PATCH] For Bots
Comment 6 Joseph Pecoraro 2018-11-14 15:56:27 PST 
<https://trac.webkit.org/r238206>
Comment 7 Radar WebKit Bug Importer 2018-11-14 15:57:28 PST 
<rdar://problem/46079224>