Bug 191485 - [MSE] Frame re-ordering can cause iframes to never be enqueued
Summary: [MSE] Frame re-ordering can cause iframes to never be enqueued
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-09 13:25 PST by Jer Noble
Modified: 2018-11-12 08:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.40 KB, patch)
2018-11-09 13:29 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.40 KB, patch)
2018-11-09 14:06 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.07 KB, patch)
2018-11-10 10:10 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (8.08 KB, patch)
2018-11-10 10:31 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (10.77 KB, patch)
2018-11-10 11:20 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (6.27 KB, patch)
2018-11-10 12:20 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (11.31 KB, patch)
2018-11-12 06:34 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-11-09 13:25:38 PST 
[MSE] Frame re-ordering can cause iframes to never be enqueued
Comment 1 Jer Noble 2018-11-09 13:29:16 PST 
Created attachment 354378 [details]
Patch
Comment 2 Eric Carlson 2018-11-09 13:31:49 PST 
Comment on attachment 354378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354378&action=review

> Source/WebCore/ChangeLog:13
> +        DTS overlaps an existing sample, but the the presentation timestamp does not.

Nit: s/the the/the/

> LayoutTests/media/media-source/media-source-dropped-iframe.html:4
> +    <title>mock-media-source</title>

Nit: this isn't terribly descriptive
Comment 3 Jer Noble 2018-11-09 14:06:35 PST 
Created attachment 354383 [details]
Patch for landing
Comment 4 Jer Noble 2018-11-10 10:10:27 PST 
Created attachment 354458 [details]
Patch for landing
Comment 5 Jer Noble 2018-11-10 10:31:04 PST 
Created attachment 354461 [details]
Patch for landing
Comment 6 Jer Noble 2018-11-10 11:20:55 PST 
Created attachment 354467 [details]
Patch
Comment 7 Jer Noble 2018-11-10 12:20:26 PST 
Created attachment 354470 [details]
Patch for landing
Comment 8 Jer Noble 2018-11-12 06:34:56 PST 
Created attachment 354555 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2018-11-12 07:12:42 PST 
Comment on attachment 354555 [details]
Patch for landing

Clearing flags on attachment: 354555

Committed r238086: <https://trac.webkit.org/changeset/238086>
Comment 10 WebKit Commit Bot 2018-11-12 07:12:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-11-12 07:13:27 PST 
<rdar://problem/45988887>