RESOLVED FIXED 191470
Use OptionSet for layout milestones 
https://bugs.webkit.org/show_bug.cgi?id=191470
Summary Use OptionSet for layout milestones
Antti Koivisto
Reported 2018-11-09 08:16:58 PST
More type safety.
Attachments
patch (71.08 KB, patch)
2018-11-09 08:20 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-11-09 08:20:56 PST
Created attachment 354345 [details] patch
EWS Watchlist
Comment 2 2018-11-09 08:22:57 PST
Attachment 354345 [details] did not pass style-queue: ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:91: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/loader/FrameLoaderClient.h:190: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-11-09 11:47:25 PST
Comment on attachment 354345 [details] patch Clearing flags on attachment: 354345 Committed r238049: <https://trac.webkit.org/changeset/238049>
WebKit Commit Bot
Comment 4 2018-11-09 11:47:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-09 11:48:26 PST
<rdar://problem/45951249>
Note You need to log in before you can comment on or make changes to this bug.