Bug 191470 - Use OptionSet for layout milestones
Summary: Use OptionSet for layout milestones
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-09 08:16 PST by Antti Koivisto
Modified: 2018-11-09 11:48 PST (History)
10 users (show)

See Also:


Attachments
patch (71.08 KB, patch)
2018-11-09 08:20 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-11-09 08:16:58 PST
More type safety.
Comment 1 Antti Koivisto 2018-11-09 08:20:56 PST
Created attachment 354345 [details]
patch
Comment 2 Build Bot 2018-11-09 08:22:57 PST
Attachment 354345 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:91:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/loader/FrameLoaderClient.h:190:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 2 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-11-09 11:47:25 PST
Comment on attachment 354345 [details]
patch

Clearing flags on attachment: 354345

Committed r238049: <https://trac.webkit.org/changeset/238049>
Comment 4 WebKit Commit Bot 2018-11-09 11:47:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-09 11:48:26 PST
<rdar://problem/45951249>