Bug 191432 - [Payment Request] canMakePayment() should not consider serialized payment method data
Summary: [Payment Request] canMakePayment() should not consider serialized payment met...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-08 12:28 PST by Andy Estes
Modified: 2018-11-09 10:28 PST (History)
13 users (show)

See Also:

Attachments
Patch (18.21 KB, patch)
2018-11-08 12:34 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (18.23 KB, patch)
2018-11-08 13:48 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-11-08 12:28:34 PST 
[Payment Request] canMakePayment() should not consider serialized payment method data
Comment 1 Andy Estes 2018-11-08 12:34:23 PST Comment hidden (obsolete)
Comment 2 Andy Estes 2018-11-08 13:48:41 PST 
Created attachment 354269 [details]
Patch
Comment 3 Dean Jackson 2018-11-09 10:17:39 PST 
Comment on attachment 354269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354269&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        * web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.

Looks like more than this was changed.
Comment 4 Andy Estes 2018-11-09 10:20:20 PST 
Comment on attachment 354269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354269&action=review

>> LayoutTests/imported/w3c/ChangeLog:8
>> +        * web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.
> 
> Looks like more than this was changed.

Yes, will fix.

Thanks for reviewing!
Comment 5 Andy Estes 2018-11-09 10:22:35 PST 
Comment on attachment 354269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354269&action=review

>>> LayoutTests/imported/w3c/ChangeLog:8
>>> +        * web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.
>> 
>> Looks like more than this was changed.
> 
> Yes, will fix.
> 
> Thanks for reviewing!

Actually no, this is all that's changed in LayoutTests/imported/w3c. The other changes are in LayoutTests/ChangeLog.
Comment 6 WebKit Commit Bot 2018-11-09 10:27:44 PST 
Comment on attachment 354269 [details]
Patch

Clearing flags on attachment: 354269

Committed r238042: <https://trac.webkit.org/changeset/238042>
Comment 7 WebKit Commit Bot 2018-11-09 10:27:46 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-09 10:28:24 PST 
<rdar://problem/45948093>