Bug 191388 - Content-Type parameter values should allow empty quoted strings
Summary: Content-Type parameter values should allow empty quoted strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-07 11:38 PST by Rob Buis
Modified: 2018-11-12 23:36 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.27 KB, patch)
2018-11-07 11:41 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.54 MB, application/zip)
2018-11-07 12:48 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.25 MB, application/zip)
2018-11-07 13:18 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.45 MB, application/zip)
2018-11-07 13:22 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-sierra (3.80 MB, application/zip)
2018-11-07 14:03 PST, EWS Watchlist
no flags Details
Patch (9.39 KB, patch)
2018-11-08 01:05 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2018-11-09 02:49 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (8.68 KB, patch)
2018-11-09 07:28 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (9.63 KB, patch)
2018-11-10 09:23 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.45 MB, application/zip)
2018-11-10 10:24 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.08 MB, application/zip)
2018-11-10 10:36 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.43 MB, application/zip)
2018-11-10 11:09 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-sierra (3.40 MB, application/zip)
2018-11-10 11:18 PST, EWS Watchlist
no flags Details
Patch (14.93 KB, patch)
2018-11-11 06:45 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-11-07 11:38:16 PST
From my reading of RFC 2048 and https://mimesniff.spec.whatwg.org/#parsing-a-mime-type, empty quoted strings are acceptable for Content-Type parameter values.
Comment 1 Rob Buis 2018-11-07 11:41:10 PST
Created attachment 354118 [details]
Patch
Comment 2 EWS Watchlist 2018-11-07 12:48:36 PST
Comment on attachment 354118 [details]
Patch

Attachment 354118 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9897056

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 3 EWS Watchlist 2018-11-07 12:48:38 PST
Created attachment 354131 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-11-07 13:18:15 PST
Comment on attachment 354118 [details]
Patch

Attachment 354118 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9897391

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 5 EWS Watchlist 2018-11-07 13:18:17 PST
Created attachment 354135 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-11-07 13:22:03 PST
Comment on attachment 354118 [details]
Patch

Attachment 354118 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9897096

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 7 EWS Watchlist 2018-11-07 13:22:05 PST
Created attachment 354136 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2018-11-07 14:02:59 PST
Comment on attachment 354118 [details]
Patch

Attachment 354118 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9897632

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
Comment 9 EWS Watchlist 2018-11-07 14:03:01 PST
Created attachment 354146 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 Rob Buis 2018-11-08 01:05:00 PST
Created attachment 354213 [details]
Patch
Comment 11 Rob Buis 2018-11-09 02:49:06 PST
Created attachment 354322 [details]
Patch
Comment 12 Rob Buis 2018-11-09 07:28:21 PST
Created attachment 354341 [details]
Patch
Comment 13 Rob Buis 2018-11-10 09:23:09 PST
Created attachment 354457 [details]
Patch
Comment 14 EWS Watchlist 2018-11-10 10:24:52 PST
Comment on attachment 354457 [details]
Patch

Attachment 354457 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9939817

New failing tests:
imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.worker.html
Comment 15 EWS Watchlist 2018-11-10 10:24:54 PST
Created attachment 354459 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 16 EWS Watchlist 2018-11-10 10:36:32 PST
Comment on attachment 354457 [details]
Patch

Attachment 354457 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9939839

New failing tests:
imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.html
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.worker.html
Comment 17 EWS Watchlist 2018-11-10 10:36:33 PST
Created attachment 354462 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 18 EWS Watchlist 2018-11-10 11:09:51 PST
Comment on attachment 354457 [details]
Patch

Attachment 354457 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9939969

New failing tests:
imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.html
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.worker.html
Comment 19 EWS Watchlist 2018-11-10 11:09:52 PST
Created attachment 354465 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 20 EWS Watchlist 2018-11-10 11:18:40 PST
Comment on attachment 354457 [details]
Patch

Attachment 354457 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9939986

New failing tests:
imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.html
imported/w3c/web-platform-tests/xhr/overridemimetype-blob.html
imported/w3c/web-platform-tests/mimesniff/mime-types/parsing.any.worker.html
Comment 21 EWS Watchlist 2018-11-10 11:18:42 PST
Created attachment 354466 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 22 Rob Buis 2018-11-11 06:45:00 PST
Created attachment 354502 [details]
Patch
Comment 23 WebKit Commit Bot 2018-11-12 23:35:47 PST
Comment on attachment 354502 [details]
Patch

Clearing flags on attachment: 354502

Committed r238124: <https://trac.webkit.org/changeset/238124>
Comment 24 WebKit Commit Bot 2018-11-12 23:35:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 25 Radar WebKit Bug Importer 2018-11-12 23:36:33 PST
<rdar://problem/46019534>