Bug 191282 - [IntersectionObserver] Account for CSS zoom when computing client rects
Summary: [IntersectionObserver] Account for CSS zoom when computing client rects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 159475
  Show dependency treegraph
 
Reported: 2018-11-05 14:57 PST by Ali Juma
Modified: 2018-11-06 07:00 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.03 KB, patch)
2018-11-05 15:02 PST, Ali Juma
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.54 MB, application/zip)
2018-11-05 17:16 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-11-05 14:57:56 PST
We need to account for CSS zoom when converting absolute rect to client rects for IntersectionObserverEntries.
Comment 1 Ali Juma 2018-11-05 15:02:51 PST
Created attachment 353911 [details]
Patch
Comment 2 Build Bot 2018-11-05 17:16:36 PST
Comment on attachment 353911 [details]
Patch

Attachment 353911 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9871572

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Comment 3 Build Bot 2018-11-05 17:16:38 PST
Created attachment 353932 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 WebKit Commit Bot 2018-11-06 06:59:20 PST
Comment on attachment 353911 [details]
Patch

Clearing flags on attachment: 353911

Committed r237862: <https://trac.webkit.org/changeset/237862>
Comment 5 WebKit Commit Bot 2018-11-06 06:59:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-06 07:00:49 PST
<rdar://problem/45841866>