Bug 191215 - Clean up drawLineForDocumentMarker()
Summary: Clean up drawLineForDocumentMarker()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 190774
  Show dependency tree / graph
 
Reported: 2018-11-02 15:25 PDT by Myles C. Maxfield
Modified: 2018-11-05 20:37 PST (History)
3 users (show)

See Also:

Attachments
Patch (44.34 KB, patch)
2018-11-02 15:32 PDT, Myles C. Maxfield 		zalan: review+
Details | Formatted Diff | Diff
Patch for committing (44.64 KB, patch)
2018-11-02 17:24 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-11-02 15:25:00 PDT 
Clean up drawLineForDocumentMarker()
Comment 1 Myles C. Maxfield 2018-11-02 15:32:51 PDT 
Created attachment 353737 [details]
Patch
Comment 2 Myles C. Maxfield 2018-11-02 17:24:01 PDT 
Created attachment 353750 [details]
Patch for committing
Comment 3 WebKit Commit Bot 2018-11-02 17:25:38 PDT 
Comment on attachment 353750 [details]
Patch for committing

Rejecting attachment 353750 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353750, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Alan Bujtas found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9838535
Comment 4 Myles C. Maxfield 2018-11-02 19:36:38 PDT 
Committed r237765: <https://trac.webkit.org/changeset/237765>
Comment 5 Radar WebKit Bug Importer 2018-11-02 19:37:22 PDT 
<rdar://problem/45779882>