Mac production builds should sign the network process xpc service with entitlements
Created attachment 353731 [details] Patch
Attachment 353731 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:3584: developmentRegion is not en. [xcodeproj/settings] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 353731 [details] Patch r=me
Comment on attachment 353731 [details] Patch Attachment 353731 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9836500 Number of test failures exceeded the failure limit.
Created attachment 353736 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Cannot reproduce test failures. http://trac.webkit.org/r237761
<rdar://problem/45778323>
Test failures were legit, rolled out in r237769
Comment on attachment 353731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353731&action=review > Source/WebKit/Configurations/NetworkService.xcconfig:35 > +CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = Configurations/Network-OSX-sandbox.entitlements; This should point to a (new) Network-OSX.entitlements. The existing Network-OSX-sandbox.entitlements gets merged in by the process-network-sandbox-entitlements.sh script iff restricted entitlements are allowed.
Created attachment 353770 [details] Patch
Attachment 353770 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:3584: developmentRegion is not en. [xcodeproj/settings] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 353772 [details] Patch
Attachment 353772 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:3584: developmentRegion is not en. [xcodeproj/settings] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/r237774