Bug 191142 - Add Justin Michaud to the list of WebKit Committers
Summary: Add Justin Michaud to the list of WebKit Committers
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-31 20:42 PDT by Justin Michaud
Modified: 2018-10-31 21:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2018-10-31 20:46 PDT, Justin Michaud 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-10-31 20:42:39 PDT 
🎉
Comment 1 Justin Michaud 2018-10-31 20:46:41 PDT 
Created attachment 353578 [details]
Patch
Comment 2 Justin Michaud 2018-10-31 20:47:47 PDT 
The style check bugged me to run `validate-committer-lists --canonicalize` which seems to have caught a few other nits in the file.
Comment 3 EWS Watchlist 2018-10-31 20:48:51 PDT 
Attachment 353578 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Saam Barati 2018-10-31 21:02:38 PDT 
Comment on attachment 353578 [details]
Patch

Heads up: You don’t need a reviewer for this type of change now that you’re a committer
Comment 5 Justin Michaud 2018-10-31 21:09:28 PDT 
Landed manually (thanks to Wenson): <https://trac.webkit.org/changeset/237668>