RESOLVED INVALID 191142
Add Justin Michaud to the list of WebKit Committers
https://bugs.webkit.org/show_bug.cgi?id=191142
Summary Add Justin Michaud to the list of WebKit Committers
Justin Michaud
Reported 2018-10-31 20:42:39 PDT
🎉
Attachments
Patch (1.71 KB, patch)
2018-10-31 20:46 PDT, Justin Michaud
saam: review+
Justin Michaud
Comment 1 2018-10-31 20:46:41 PDT
Justin Michaud
Comment 2 2018-10-31 20:47:47 PDT
The style check bugged me to run `validate-committer-lists --canonicalize` which seems to have caught a few other nits in the file.
EWS Watchlist
Comment 3 2018-10-31 20:48:51 PDT
Attachment 353578 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 4 2018-10-31 21:02:38 PDT
Comment on attachment 353578 [details] Patch Heads up: You don’t need a reviewer for this type of change now that you’re a committer
Justin Michaud
Comment 5 2018-10-31 21:09:28 PDT
Landed manually (thanks to Wenson): <https://trac.webkit.org/changeset/237668>
Note You need to log in before you can comment on or make changes to this bug.