RESOLVED FIXED 191068
PNGImageDecoder: report no repetition for non-animated images 
https://bugs.webkit.org/show_bug.cgi?id=191068
Summary PNGImageDecoder: report no repetition for non-animated images
Zan Dobersek
Reported 2018-10-30 08:17:10 PDT
PNGImageDecoder: report no repetition for non-animated images
Attachments
Patch (1.85 KB, patch)
2018-10-30 08:20 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-10-30 08:20:02 PDT
Created attachment 353370 [details] Patch
Michael Catanzaro
Comment 2 2018-10-30 08:22:44 PDT
Comment on attachment 353370 [details] Patch Does this fix something? Is it testable?
Zan Dobersek
Comment 3 2018-10-30 08:40:45 PDT
This avoids querying the PNG decoder for duration information on non-animated images. As it stands, that query goes on and needlessly decodes all the PNG data. Combined with other issues in ScalableImageDecoder, size of all that decoded data goes unreported to the MemoryCache, which means that MemoryCache ends up handling more data than it knows about. So currently, there's no simple way to test it yet.
Miguel Gomez
Comment 4 2018-10-30 08:55:09 PDT
Yeah, makes sense.
Zan Dobersek
Comment 5 2018-11-02 00:15:16 PDT
Comment on attachment 353370 [details] Patch Clearing flags on attachment: 353370 Committed r237725: <https://trac.webkit.org/changeset/237725>
Zan Dobersek
Comment 6 2018-11-02 00:15:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-02 00:16:21 PDT
<rdar://problem/45755638>
Note You need to log in before you can comment on or make changes to this bug.