RESOLVED FIXED190957
Use random() instead of begin() to limit cache sizes 
https://bugs.webkit.org/show_bug.cgi?id=190957
Summary Use random() instead of begin() to limit cache sizes
Antti Koivisto
Reported 2018-10-26 05:53:29 PDT
We use cache.remove(cache.begin()) pattern to limit sized of various caches. This is a bad pattern for tables that never rehash (because they have fixed maximum size) as most of the keys get permanently stuck in the table.
Attachments
patch (8.07 KB, patch)
2018-10-26 06:48 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-10-26 06:48:42 PDT
Created attachment 353180 [details] patch
Chris Dumez
Comment 2 2018-10-26 08:10:54 PDT
Red bubbles.
Antti Koivisto
Comment 3 2018-10-26 08:19:02 PDT
(In reply to Chris Dumez from comment #2) > Red bubbles. Because of the blocking bug.
Chris Dumez
Comment 4 2018-10-26 08:42:29 PDT
(In reply to Antti Koivisto from comment #3) > (In reply to Chris Dumez from comment #2) > > Red bubbles. > > Because of the blocking bug. Oh duh, I was on my phone, sorry.
Chris Dumez
Comment 5 2018-10-26 08:43:54 PDT
Comment on attachment 353180 [details] patch r=me
WebKit Commit Bot
Comment 6 2018-10-26 10:07:58 PDT
Comment on attachment 353180 [details] patch Clearing flags on attachment: 353180 Committed r237463: <https://trac.webkit.org/changeset/237463>
WebKit Commit Bot
Comment 7 2018-10-26 10:07:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-26 10:08:42 PDT
<rdar://problem/45591018>
Note You need to log in before you can comment on or make changes to this bug.