Bug 190876 - [High Sierra/Sierra Release] Layout Test media/track/track-cue-css.html is a flaky image failure
Summary: [High Sierra/Sierra Release] Layout Test media/track/track-cue-css.html is a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-24 09:25 PDT by Ryan Haddad
Modified: 2018-10-26 10:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2018-10-24 14:02 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2018-10-26 10:03 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-10-24 09:25:30 PDT 
The following layout test is flaky on High Sierra and Sierra Release

media/track/track-cue-css.html

Probable cause:

Unknown, this flakiness started on 10/16/2018 around r237203.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-cue-css.html

Link to image diff:
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r237379%20(8750)/media/track/track-cue-css-diffs.html
Comment 1 Ryan Haddad 2018-10-24 09:28:33 PDT 
Oh, this is a new test added with https://trac.webkit.org/changeset/237187

It was called out as flaky in https://bugs.webkit.org/show_bug.cgi?id=190369#c9
Comment 2 Per Arne Vollan 2018-10-24 14:02:28 PDT 
Created attachment 353052 [details]
Patch
Comment 3 Per Arne Vollan 2018-10-25 10:19:03 PDT 
Comment on attachment 353052 [details]
Patch

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2018-10-25 10:44:45 PDT 
Comment on attachment 353052 [details]
Patch

Clearing flags on attachment: 353052

Committed r237420: <https://trac.webkit.org/changeset/237420>
Comment 5 WebKit Commit Bot 2018-10-25 10:44:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-25 10:45:32 PDT 
<rdar://problem/45558540>
Comment 7 Ryan Haddad 2018-10-26 08:57:45 PDT 
The test is still a flaky failure, but now it looks like the caption is present but the video is missing:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r237451%20(12379)/media/track/track-cue-css-diffs.html
Comment 8 Per Arne Vollan 2018-10-26 10:03:11 PDT 
Created attachment 353188 [details]
Patch
Comment 9 WebKit Commit Bot 2018-10-26 10:44:47 PDT 
Comment on attachment 353188 [details]
Patch

Clearing flags on attachment: 353188

Committed r237465: <https://trac.webkit.org/changeset/237465>
Comment 10 WebKit Commit Bot 2018-10-26 10:44:49 PDT 
All reviewed patches have been landed.  Closing bug.