Bug 190717 - [PSON] WebPageProxy::didCompletePageTransition() may interact with a SuspendedPageProxy from a previous navigation
Summary: [PSON] WebPageProxy::didCompletePageTransition() may interact with a Suspende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 09:13 PDT by Chris Dumez
Modified: 2018-10-19 06:40 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.56 KB, patch)
2018-10-18 09:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.71 MB, application/zip)
2018-10-18 11:05 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-18 09:13:02 PDT 
WebPageProxy::didCompletePageTransition() may interact with a SuspendedPageProxy from a previous navigation. We need to reset m_lastSuspendedPage whenever the page starts a new navigation as m_lastSuspendedPage is only updated when we process-swap otherwise.
Comment 1 Chris Dumez 2018-10-18 09:15:12 PDT 
Created attachment 352697 [details]
Patch
Comment 2 EWS Watchlist 2018-10-18 11:04:54 PDT 
Comment on attachment 352697 [details]
Patch

Attachment 352697 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9652399

New failing tests:
webanimations/leak-document-with-web-animation.html
Comment 3 EWS Watchlist 2018-10-18 11:05:05 PDT 
Created attachment 352708 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Chris Dumez 2018-10-18 11:56:54 PDT 
Comment on attachment 352708 [details]
Archive of layout-test-results from ews205 for win-future

Cannot be related.
Comment 5 WebKit Commit Bot 2018-10-19 06:39:39 PDT 
Comment on attachment 352697 [details]
Patch

Clearing flags on attachment: 352697

Committed r237283: <https://trac.webkit.org/changeset/237283>
Comment 6 WebKit Commit Bot 2018-10-19 06:39:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-19 06:40:56 PDT 
<rdar://problem/45404107>