Bug 190635 - Free WebBackForwardList from the shackles of the WebProcess
Summary: Free WebBackForwardList from the shackles of the WebProcess
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-16 12:11 PDT by Alex Christensen
Modified: 2018-12-21 10:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (20.65 KB, patch)
2018-10-16 12:16 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.71 MB, application/zip)
2018-10-16 17:39 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (4.93 MB, application/zip)
2018-10-16 19:30 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (69.08 MB, application/zip)
2018-10-16 21:55 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (69.19 MB, application/zip)
2018-10-16 23:47 PDT, EWS Watchlist
no flags Details
Patch (24.77 KB, patch)
2018-10-17 20:44 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-10-16 12:11:25 PDT
Free WebBackForwardList from the shackles of the WebProcess
Comment 1 Alex Christensen 2018-10-16 12:16:24 PDT
Created attachment 352487 [details]
Patch
Comment 2 Chris Dumez 2018-10-16 13:58:08 PDT
The failures look related.
Comment 3 Alex Christensen 2018-10-16 13:58:50 PDT
They are :(
Comment 4 EWS Watchlist 2018-10-16 17:39:53 PDT
Comment on attachment 352487 [details]
Patch

Attachment 352487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9628320

New failing tests:
http/tests/navigation/success200-goback.html
http/tests/navigation/redirect302-goback.html
http/tests/navigation/restore-form-state-https.html
http/tests/navigation/post-goback-same-url.html
http/tests/navigation/relativeanchor-goback.html
swipe/basic-cached-back-swipe.html
http/tests/navigation/timerredirect-goback.html
http/tests/navigation/go-back-to-error-page.html
http/tests/navigation/postredirect-goback1.html
http/tests/navigation/javascriptlink-goback.html
compositing/show-composited-iframe-on-back-button.html
http/tests/navigation/anchor-goback.html
http/tests/navigation/error404-goback.html
http/tests/navigation/post-goback2.html
http/tests/navigation/back-to-slow-frame.html
fast/dom/navigation-type-back-forward.html
swipe/pushState-cached-back-swipe.html
http/tests/navigation/metaredirect-goback.html
fast/images/animated-gif-restored-from-bfcache.html
http/tests/navigation/postredirect-goback2.html
fast/history/go-back-to-changed-name.html
Comment 5 EWS Watchlist 2018-10-16 17:39:55 PDT
Created attachment 352526 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-10-16 19:30:04 PDT
Comment on attachment 352487 [details]
Patch

Attachment 352487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9629881

New failing tests:
http/tests/navigation/success200-goback.html
http/tests/navigation/redirect302-goback.html
http/tests/navigation/restore-form-state-https.html
http/tests/navigation/post-goback-same-url.html
http/tests/navigation/relativeanchor-goback.html
swipe/basic-cached-back-swipe.html
http/tests/navigation/timerredirect-goback.html
http/tests/navigation/go-back-to-error-page.html
http/tests/navigation/postredirect-goback1.html
http/tests/navigation/javascriptlink-goback.html
compositing/show-composited-iframe-on-back-button.html
http/tests/navigation/anchor-goback.html
http/tests/navigation/error404-goback.html
http/tests/navigation/post-goback2.html
http/tests/navigation/back-to-slow-frame.html
fast/dom/navigation-type-back-forward.html
swipe/pushState-cached-back-swipe.html
http/tests/navigation/metaredirect-goback.html
fast/images/animated-gif-restored-from-bfcache.html
http/tests/navigation/postredirect-goback2.html
fast/history/go-back-to-changed-name.html
Comment 7 EWS Watchlist 2018-10-16 19:30:06 PDT
Created attachment 352537 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-10-16 21:55:15 PDT
Comment on attachment 352487 [details]
Patch

Attachment 352487 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9630714

New failing tests:
http/tests/navigation/success200-goback.html
http/tests/navigation/redirect302-goback.html
http/tests/navigation/post-goback-same-url.html
http/tests/navigation/relativeanchor-goback.html
http/tests/navigation/timerredirect-goback.html
http/tests/navigation/go-back-to-error-page.html
http/tests/navigation/restore-form-state-https.html
compositing/show-composited-iframe-on-back-button.html
http/tests/navigation/anchor-goback.html
fast/images/animated-gif-restored-from-bfcache.html
http/tests/navigation/post-goback2.html
http/tests/navigation/back-to-slow-frame.html
fast/dom/navigation-type-back-forward.html
http/tests/navigation/metaredirect-goback.html
http/tests/navigation/error404-goback.html
http/tests/navigation/postredirect-goback2.html
fast/history/go-back-to-changed-name.html
Comment 9 EWS Watchlist 2018-10-16 21:55:21 PDT
Created attachment 352550 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 10 EWS Watchlist 2018-10-16 23:47:27 PDT
Comment on attachment 352487 [details]
Patch

Attachment 352487 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9631709

New failing tests:
http/tests/navigation/success200-goback.html
http/tests/navigation/redirect302-goback.html
http/tests/navigation/post-goback-same-url.html
http/tests/navigation/relativeanchor-goback.html
http/tests/navigation/timerredirect-goback.html
http/tests/navigation/go-back-to-error-page.html
http/tests/navigation/restore-form-state-https.html
compositing/show-composited-iframe-on-back-button.html
http/tests/navigation/anchor-goback.html
fast/images/animated-gif-restored-from-bfcache.html
http/tests/navigation/post-goback2.html
http/tests/navigation/back-to-slow-frame.html
fast/dom/navigation-type-back-forward.html
http/tests/navigation/metaredirect-goback.html
http/tests/navigation/error404-goback.html
http/tests/navigation/postredirect-goback2.html
fast/history/go-back-to-changed-name.html
Comment 11 EWS Watchlist 2018-10-16 23:47:31 PDT
Created attachment 352554 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 12 Alex Christensen 2018-10-17 20:44:52 PDT
Created attachment 352682 [details]
Patch
Comment 13 Alex Christensen 2018-10-17 20:46:03 PDT
This last patch passes all tests except the ProcessSwap.BackWithoutSuspendedPage API test.  It fails that test because the call to itemsAreClones in HistoryController::recursiveGoToItem prevents the load.