WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190389
Have DOMWindow get its frame from its document
https://bugs.webkit.org/show_bug.cgi?id=190389
Summary
Have DOMWindow get its frame from its document
Chris Dumez
Reported
2018-10-08 20:40:12 PDT
Have DOMWindow get its frame from its document instead of having its own m_frame which can potentially be out-of-sync.
Attachments
Patch
(38.77 KB, patch)
2018-10-08 20:41 PDT
,
Chris Dumez
ggaren
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-10-08 20:41:32 PDT
Created
attachment 351852
[details]
Patch
Geoffrey Garen
Comment 2
2018-10-09 10:02:51 PDT
Comment on
attachment 351852
[details]
Patch r=me
WebKit Commit Bot
Comment 3
2018-10-09 10:05:26 PDT
Comment on
attachment 351852
[details]
Patch Rejecting
attachment 351852
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 351852, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
https://webkit-queues.webkit.org/results/9504755
Chris Dumez
Comment 4
2018-10-09 10:15:27 PDT
Committed
r236965
: <
https://trac.webkit.org/changeset/236965
>
Radar WebKit Bug Importer
Comment 5
2018-10-09 10:16:29 PDT
<
rdar://problem/45129703
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug