Bug 190389 - Have DOMWindow get its frame from its document
Summary: Have DOMWindow get its frame from its document
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-08 20:40 PDT by Chris Dumez
Modified: 2018-10-09 10:16 PDT (History)
11 users (show)

See Also:

Attachments
Patch (38.77 KB, patch)
2018-10-08 20:41 PDT, Chris Dumez 		ggaren: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-08 20:40:12 PDT 
Have DOMWindow get its frame from its document instead of having its own m_frame which can potentially be out-of-sync.
Comment 1 Chris Dumez 2018-10-08 20:41:32 PDT 
Created attachment 351852 [details]
Patch
Comment 2 Geoffrey Garen 2018-10-09 10:02:51 PDT 
Comment on attachment 351852 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-10-09 10:05:26 PDT 
Comment on attachment 351852 [details]
Patch

Rejecting attachment 351852 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 351852, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/9504755
Comment 4 Chris Dumez 2018-10-09 10:15:27 PDT 
Committed r236965: <https://trac.webkit.org/changeset/236965>
Comment 5 Radar WebKit Bug Importer 2018-10-09 10:16:29 PDT 
<rdar://problem/45129703>