WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190072
Web Inspector: image resources without content are still shown when the Images folder is selected
https://bugs.webkit.org/show_bug.cgi?id=190072
Summary
Web Inspector: image resources without content are still shown when the Image...
Devin Rousso
Reported
2018-09-27 23:42:55 PDT
In inspector2, clicking on the "Images" folder will show the list of images used by WebInspector. Since we use a lot of SVG fragment images, these won't display properly. As a result, a large "Resource has no content" over the entire content area, making it impossible to see any other images. We should remove the image's `WI.ImageResourceContentView` if it has no content, just like how we remove it if there's an error.
Attachments
Patch
(1.55 KB, patch)
2018-09-27 23:44 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2018-09-27 23:44:29 PDT
Created
attachment 351059
[details]
Patch
Matt Baker
Comment 2
2018-09-28 00:31:44 PDT
I tried to repro this and was able to view some images and not others. Steps to reproduce or screenshots would be help to clarify and illustrate the problem.
Matt Baker
Comment 3
2018-09-28 00:37:18 PDT
(In reply to Matt Baker from
comment #2
)
> I tried to repro this and was able to view some images and not others. Steps > to reproduce or screenshots would be help to clarify and illustrate the > problem.
Disregard, I misread the bug description.
Matt Baker
Comment 4
2018-09-28 00:38:13 PDT
Comment on
attachment 351059
[details]
Patch r=me
WebKit Commit Bot
Comment 5
2018-09-28 01:04:17 PDT
Comment on
attachment 351059
[details]
Patch Clearing flags on attachment: 351059 Committed
r236596
: <
https://trac.webkit.org/changeset/236596
>
WebKit Commit Bot
Comment 6
2018-09-28 01:04:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-09-28 01:05:42 PDT
<
rdar://problem/44857443
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug