Bug 189852 - REGRESSION(r236237): Web Inspector: DarkMode: white background in Elements and Timelines
Summary: REGRESSION(r236237): Web Inspector: DarkMode: white background in Elements an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 13:05 PDT by Matt Baker
Modified: 2018-09-21 14:06 PDT (History)
4 users (show)

See Also:


Attachments
[Image] Elements tab (655.51 KB, image/png)
2018-09-21 13:05 PDT, Matt Baker
no flags Details
[Image] Timelines tab (514.94 KB, image/png)
2018-09-21 13:05 PDT, Matt Baker
no flags Details
Patch (1.39 KB, patch)
2018-09-21 13:19 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-09-21 13:05:30 PDT
Created attachment 350410 [details]
[Image] Elements tab

It looks like mostly an issue with background-color on a view classes. See attached screenshots.

This probably regressed in https://bugs.webkit.org/show_bug.cgi?id=189673.
Comment 1 Matt Baker 2018-09-21 13:05:47 PDT
Created attachment 350411 [details]
[Image] Timelines tab
Comment 2 Nikita Vasilyev 2018-09-21 13:19:08 PDT
Created attachment 350412 [details]
Patch
Comment 3 Joseph Pecoraro 2018-09-21 13:27:35 PDT
Comment on attachment 350412 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-09-21 14:05:04 PDT
Comment on attachment 350412 [details]
Patch

Clearing flags on attachment: 350412

Committed r236358: <https://trac.webkit.org/changeset/236358>
Comment 5 WebKit Commit Bot 2018-09-21 14:05:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-21 14:06:28 PDT
<rdar://problem/44691565>