Bug 189784 - [Web Animations] DocumentTimeline::updateAnimations() is called endlessly
Summary: [Web Animations] DocumentTimeline::updateAnimations() is called endlessly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-20 05:45 PDT by Antoine Quint
Modified: 2018-09-26 03:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.57 KB, patch)
2018-09-20 06:40 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.79 MB, application/zip)
2018-09-20 10:36 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-09-20 05:45:58 PDT 
We end up re-scheduling animation resolution on the immediate next run loop indefinitely when an element that had an accelerated animation applied has its renderer removed, for instance when "display: none" is set. This affects YouTube and yields very high power usage.
Comment 1 Antoine Quint 2018-09-20 05:46:13 PDT 
<rdar://problem/41705679>
Comment 2 Antoine Quint 2018-09-20 06:40:41 PDT 
Created attachment 350193 [details]
Patch
Comment 3 EWS Watchlist 2018-09-20 10:36:16 PDT 
Comment on attachment 350193 [details]
Patch

Attachment 350193 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9282831

New failing tests:
webanimations/accelerated-animation-interruption-display-none.html
Comment 4 EWS Watchlist 2018-09-20 10:36:27 PDT 
Created attachment 350229 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Antoine Quint 2018-09-21 04:28:48 PDT 
Committed r236308: <https://trac.webkit.org/changeset/236308>