Bug 189762 - [Web Animations] Provide a way to query accelerated animations for internal testing
Summary: [Web Animations] Provide a way to query accelerated animations for internal t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-19 12:35 PDT by Antoine Quint
Modified: 2018-09-20 00:35 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.83 KB, patch)
2018-09-19 12:37 PDT, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-09-19 12:35:44 PDT 
[Web Animations] Provide a way to query accelerated animations for internal testing
Comment 1 Antoine Quint 2018-09-19 12:37:24 PDT 
Created attachment 350142 [details]
Patch
Comment 2 Dean Jackson 2018-09-19 16:50:44 PDT 
Comment on attachment 350142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350142&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4245
> +            const auto& propertyAnimations = it.value;

Is there a benefit to saying const?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:174
> +    WEBCORE_EXPORT Vector<std::pair<String, double>> acceleratedAnimationsForTesting() const override;

This could probably be final.
Comment 3 Antoine Quint 2018-09-20 00:33:49 PDT 
Committed r236247: <https://trac.webkit.org/changeset/236247>
Comment 4 Radar WebKit Bug Importer 2018-09-20 00:35:29 PDT 
<rdar://problem/44631995>