Bug 189730 - [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'
Summary: [Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 171618
  Show dependency tree / graph
 
Reported: 2018-09-18 20:21 PDT by Fujii Hironori
Modified: 2018-09-20 00:45 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2018-09-18 20:38 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-09-18 20:21:29 PDT 
[Win][Clang] JITMathIC.h: error: missing 'template' keyword prior to dependent template name 'retagged'

While doing Bug 171618, following compilation error is reported.

> [4/1360] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\__\__\DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp.obj
> FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource80.cpp.obj 
> C:\tools\llvm\bin\clang-cl.exe (...) -c DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp
> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp:1:
> In file included from ..\..\Source\JavaScriptCore\jit/JITOpcodes.cpp:29:
> ..\..\Source\JavaScriptCore\jit/JIT.h(745,31):  warning: explicit specialization cannot have a storage class
>         static constexpr bool is64BitType<void>() { return true; }
>         ~~~~~~~               ^
> In file included from DerivedSources\JavaScriptCore\unified-sources\UnifiedSource80.cpp:1:
> In file included from ..\..\Source\JavaScriptCore\jit/JITOpcodes.cpp:29:
> In file included from ..\..\Source\JavaScriptCore\jit/JIT.h:44:
> ..\..\Source\JavaScriptCore\jit/JITMathIC.h(148,72):  error: missing 'template' keyword prior to dependent template name 'retagged'
>             ftlThunkAwareRepatchCall(codeBlock, slowPathCallLocation().retagged<JSInternalPtrTag>(), callReplacement);
>                                                                        ^       ~~~~~~~~~~~~~~~~~~
> 1 warning and 1 error generated.
Comment 1 Fujii Hironori 2018-09-18 20:38:42 PDT 
Created attachment 350090 [details]
Patch
Comment 2 Fujii Hironori 2018-09-20 00:44:13 PDT 
Comment on attachment 350090 [details]
Patch

Clearing flags on attachment: 350090

Committed r236248: <https://trac.webkit.org/changeset/236248>
Comment 3 Fujii Hironori 2018-09-20 00:44:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-09-20 00:45:27 PDT 
<rdar://problem/44632168>