Bug 189698 - [css-grid] Static position should use content-box, not padding-box
Summary: [css-grid] Static position should use content-box, not padding-box
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-18 06:09 PDT by Manuel Rego Casasnovas
Modified: 2018-09-18 08:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.02 KB, patch)
2018-09-18 06:09 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch for landing (6.01 KB, patch)
2018-09-18 07:34 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2018-09-18 06:09:01 PDT
[css-grid] Static position should use content-box, not padding-box
Comment 1 Manuel Rego Casasnovas 2018-09-18 06:09:28 PDT
Created attachment 350016 [details]
Patch
Comment 2 Javier Fernandez 2018-09-18 07:10:08 PDT
Comment on attachment 350016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350016&action=review

> Source/WebCore/rendering/RenderGrid.cpp:907
> +    // (https://drafts.csswg.org/css-grid/#static-position).

There is no need to wrap the line in this comment.
Comment 3 Manuel Rego Casasnovas 2018-09-18 07:34:23 PDT
Created attachment 350020 [details]
Patch for landing
Comment 4 Manuel Rego Casasnovas 2018-09-18 07:35:21 PDT
Comment on attachment 350016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350016&action=review

Thanks for the review.

>> Source/WebCore/rendering/RenderGrid.cpp:907
>> +    // (https://drafts.csswg.org/css-grid/#static-position).
> 
> There is no need to wrap the line in this comment.

Ok, fixed.
Comment 5 WebKit Commit Bot 2018-09-18 08:13:49 PDT
Comment on attachment 350020 [details]
Patch for landing

Clearing flags on attachment: 350020

Committed r236126: <https://trac.webkit.org/changeset/236126>
Comment 6 WebKit Commit Bot 2018-09-18 08:13:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-18 08:14:24 PDT
<rdar://problem/44560634>