Bug 189071 - [CMake] Use CMake's FindFreetype
Summary: [CMake] Use CMake's FindFreetype
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-28 17:45 PDT by Don Olmstead
Modified: 2018-08-28 20:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2018-08-28 17:49 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (8.01 KB, patch)
2018-08-28 17:56 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-08-28 17:45:17 PDT 
Back in https://bugs.webkit.org/show_bug.cgi?id=130150 a FreeType2.cmake file was introduced. This seems to be completely legacy.
Comment 1 Don Olmstead 2018-08-28 17:49:29 PDT 
Created attachment 348368 [details]
Patch

Let's see if GTK and WPE are happy with this change
Comment 2 EWS Watchlist 2018-08-28 17:52:02 PDT 
Attachment 348368 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-08-28 17:56:20 PDT 
Created attachment 348369 [details]
Patch

Make style checker happy
Comment 4 WebKit Commit Bot 2018-08-28 20:58:39 PDT 
Comment on attachment 348369 [details]
Patch

Clearing flags on attachment: 348369

Committed r235454: <https://trac.webkit.org/changeset/235454>
Comment 5 WebKit Commit Bot 2018-08-28 20:58:41 PDT 
All reviewed patches have been landed.  Closing bug.