Bug 188956 – [Xcode] Don’t make unnecessary, broken WebKitPluginAgent symlink when WK_USE_OVERRIDE_FRAMEWORKS_DIR=YES

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

<rdar://problem/43253221>

Created attachment 348103 [details]
Update the build phase that makes the symlink

[WebKit Commit Bot]

Comment on attachment 348103 [details]
Update the build phase that makes the symlink

Rejecting attachment 348103 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 348103, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348103&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=188956&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 348103 from bug 188956.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348103
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKitLegacy/ChangeLog
	M	Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 3e5c51ff171204665ccb28e40b46b9c75d56067f and refs/remotes/origin/master differ, using rebase:
:040000 040000 7f21da625bc17a78b3bd037b8a7e1f3c61147a02 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKitLegacy/ChangeLog
	M	Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: 3e5c51ff171204665ccb28e40b46b9c75d56067f and refs/remotes/origin/master differ, using rebase:
:040000 040000 7f21da625bc17a78b3bd037b8a7e1f3c61147a02 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/8990191

[WebKit Commit Bot]

Comment on attachment 348103 [details]
Update the build phase that makes the symlink

Clearing flags on attachment: 348103

Committed r235340: <https://trac.webkit.org/changeset/235340>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.