Bug 188947 - [Apple Pay] Add a test for rendering Apple Pay buttons
Summary: [Apple Pay] Add a test for rendering Apple Pay buttons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-25 12:12 PDT by Andy Estes
Modified: 2018-08-27 13:17 PDT (History)
9 users (show)

See Also:


Attachments
Patch (40.83 KB, patch)
2018-08-25 12:15 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.89 MB, application/zip)
2018-08-25 13:31 PDT, EWS Watchlist
no flags Details
Patch (83.44 KB, patch)
2018-08-25 15:40 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-08-25 12:12:26 PDT
[Apple Pay] Add a test for rendering Apple Pay buttons
Comment 1 Andy Estes 2018-08-25 12:15:22 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2018-08-25 13:31:26 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-08-25 13:31:28 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2018-08-25 15:40:51 PDT
Created attachment 348084 [details]
Patch
Comment 5 WebKit Commit Bot 2018-08-26 18:27:08 PDT
Comment on attachment 348084 [details]
Patch

Clearing flags on attachment: 348084

Committed r235341: <https://trac.webkit.org/changeset/235341>
Comment 6 WebKit Commit Bot 2018-08-26 18:27:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-26 18:28:17 PDT
<rdar://problem/43739206>
Comment 8 Simon Fraser (smfr) 2018-08-27 13:12:44 PDT
Comment on attachment 348084 [details]
Patch

This test is useless. We don't run pixel tests. Also see LayoutTests/css/appearance-apple-pay-button.html
Comment 9 Andy Estes 2018-08-27 13:17:30 PDT
(In reply to Simon Fraser (smfr) from comment #8)
> Comment on attachment 348084 [details]
> Patch
> 
> This test is useless. We don't run pixel tests. Also see
> LayoutTests/css/appearance-apple-pay-button.html

"Useless" seems like an overstatement. The metrics of the buttons can change, and I can run the pixel tests at my desk.