Bug 188748 - Add _WKWebsiteDataStoreConfiguration. sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Summary: Add _WKWebsiteDataStoreConfiguration. sourceApplicationBundleIdentifier and s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-20 10:46 PDT by Alex Christensen
Modified: 2018-08-21 11:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.56 KB, patch)
2018-08-20 10:47 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (13.48 KB, patch)
2018-08-20 12:39 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (657.52 KB, application/zip)
2018-08-20 13:56 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (44.53 MB, application/zip)
2018-08-20 14:19 PDT, EWS Watchlist
no flags Details
Patch (13.53 KB, patch)
2018-08-20 16:12 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-20 10:46:57 PDT
Add _WKWebsiteDataStoreConfiguration. sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
Comment 1 Alex Christensen 2018-08-20 10:47:46 PDT
Created attachment 347509 [details]
Patch
Comment 2 Alex Christensen 2018-08-20 12:39:32 PDT
Created attachment 347532 [details]
Patch
Comment 3 EWS Watchlist 2018-08-20 13:56:11 PDT
Comment on attachment 347532 [details]
Patch

Attachment 347532 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8920783

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-08-20 13:56:12 PDT
Created attachment 347539 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-08-20 14:19:51 PDT
Comment on attachment 347532 [details]
Patch

Attachment 347532 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8920711

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2018-08-20 14:19:53 PDT
Created attachment 347541 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 7 Alex Christensen 2018-08-20 16:12:29 PDT
Created attachment 347556 [details]
Patch
Comment 8 Ryosuke Niwa 2018-08-20 19:32:25 PDT
Comment on attachment 347556 [details]
Patch

Looks sane to me.
Comment 9 WebKit Commit Bot 2018-08-21 11:12:41 PDT
Comment on attachment 347556 [details]
Patch

Clearing flags on attachment: 347556

Committed r235127: <https://trac.webkit.org/changeset/235127>
Comment 10 WebKit Commit Bot 2018-08-21 11:12:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-08-21 11:13:40 PDT
<rdar://problem/43569012>