Bug 188637 - Custom element doesn't invalidate its style when :defined rule starts to apply
Summary: Custom element doesn't invalidate its style when :defined rule starts to apply
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency tree / graph
 
Reported: 2018-08-15 22:26 PDT by Ryosuke Niwa
Modified: 2018-08-16 13:50 PDT (History)
12 users (show)

See Also:

Attachments
Fixes the bug (6.33 KB, patch)
2018-08-15 22:40 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.38 MB, application/zip)
2018-08-15 23:46 PDT, Build Bot 		no flags Details
Patch for landing (6.43 KB, patch)
2018-08-16 12:32 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-15 22:26:05 PDT 
Yet another style recalc bug we have for web components :(
Comment 1 Radar WebKit Bug Importer 2018-08-15 22:33:33 PDT 
<rdar://problem/43366526>
Comment 2 Ryosuke Niwa 2018-08-15 22:40:15 PDT 
Created attachment 347247 [details]
Fixes the bug
Comment 3 Build Bot 2018-08-15 23:46:53 PDT 
Comment on attachment 347247 [details]
Fixes the bug

Attachment 347247 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8877024

New failing tests:
fast/custom-elements/defined-update-style.html
Comment 4 Build Bot 2018-08-15 23:46:55 PDT 
Created attachment 347249 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Ryosuke Niwa 2018-08-16 12:32:34 PDT 
Created attachment 347286 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2018-08-16 12:33:02 PDT 
Comment on attachment 347286 [details]
Patch for landing

Thanks for the review! Wait for EWS again now that I've fixed the test.
Comment 7 WebKit Commit Bot 2018-08-16 13:50:09 PDT 
Comment on attachment 347286 [details]
Patch for landing

Clearing flags on attachment: 347286

Committed r234953: <https://trac.webkit.org/changeset/234953>
Comment 8 WebKit Commit Bot 2018-08-16 13:50:11 PDT 
All reviewed patches have been landed.  Closing bug.