RESOLVED FIXED 188449
Web Inspector: Remove TreeOutlineDataGridSynchronizer 
https://bugs.webkit.org/show_bug.cgi?id=188449
Summary Web Inspector: Remove TreeOutlineDataGridSynchronizer
Matt Baker
Reported 2018-08-09 13:21:40 PDT
It is no longer used, now that the Network grid now uses WI.Table.
Attachments
Patch (26.37 KB, patch)
2018-08-09 13:26 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.01 KB, patch)
2018-08-21 17:02 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-09 13:22:48 PDT
<rdar://problem/43107980>
Matt Baker
Comment 2 2018-08-09 13:26:27 PDT
Created attachment 346859 [details] Patch
Devin Rousso
Comment 3 2018-08-14 21:57:46 PDT
Comment on attachment 346859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346859&action=review r=me, nice cleanup > Source/WebInspectorUI/ChangeLog:27 > + (WI.TimelineDataGrid.prototype.dataGridNodeForTreeElement): Deleted. This function also seems to be defined on `WI.RenderingFrameTimelineView`. Is that related, or "leftover"?
Matt Baker
Comment 4 2018-08-21 17:02:54 PDT
Created attachment 347732 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-08-21 18:08:54 PDT
Comment on attachment 347732 [details] Patch for landing Clearing flags on attachment: 347732 Committed r235151: <https://trac.webkit.org/changeset/235151>
WebKit Commit Bot
Comment 6 2018-08-21 18:08:56 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 7 2018-08-21 19:39:10 PDT
CC Adrian: I think *every* GTK and WPE bot needs a clean build now: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/TreeOutlineDataGridSynchronizer.js', needed by 'inspector-resources.stamp', missing and no known rule to make it Problem is Source/WebKit/InspectorGResources.cmake doesn't have any way to deal with removed JS files.
Carlos Garcia Campos
Comment 8 2018-08-22 00:07:37 PDT
TreeOutlineDataGridSynchronizer.js is still included in WebInspectorUI/UserInterface/Main.html
Carlos Garcia Campos
Comment 9 2018-08-22 00:13:30 PDT
Committed r235163: <https://trac.webkit.org/changeset/235163>
Michael Catanzaro
Comment 10 2018-08-22 06:50:33 PDT
(In reply to Carlos Garcia Campos from comment #8) > TreeOutlineDataGridSynchronizer.js is still included in > WebInspectorUI/UserInterface/Main.html Ah, whew! Much better problem to have.
Matt Baker
Comment 11 2018-08-22 09:52:24 PDT
(In reply to Carlos Garcia Campos from comment #8) > TreeOutlineDataGridSynchronizer.js is still included in > WebInspectorUI/UserInterface/Main.html Oops! Thanks for fixing.
Note You need to log in before you can comment on or make changes to this bug.