Bug 188403 – [css-grid] Update behavior of percentage row tracks and gutters

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Manuel Rego Casasnovas]

This bug is to adapt WebKit to the following resolutions by the CSSWG:
* Percentage row tracks: https://github.com/w3c/csswg-drafts/issues/1921
* Percentage row gutters: https://github.com/w3c/csswg-drafts/issues/509

The change has been already done in Blink (https://chromium.googlesource.com/chromium/src/+/47bfc59ccdda82e2b28817a653c792d7a606ee8e)
so it'd be nice to follow it in WebKit too.

Change for percentage row gutters has been also done in Firefox already.

[Manuel Rego Casasnovas]

Created attachment 346757 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 346757 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346757&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties.html:97
> +        '<track-size>.<track-breadth>.<percentage>': ['100%', '150px 50px 50px'],

Created PR in WPT for this change (as this was not in the repo yet):
https://github.com/web-platform-tests/wpt/pull/12349

Please review and merge the PR first before landing this patch.

[Sergio Villar Senin]

Comment on attachment 346757 [details]
Patch

Great stuff!

[WebKit Commit Bot]

Comment on attachment 346757 [details]
Patch

Clearing flags on attachment: 346757

Committed r234687: <https://trac.webkit.org/changeset/234687>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43039111>