Bug 188361 - webkitdirs.pm should default to iPhone SE for 64-bit testing
Summary: webkitdirs.pm should default to iPhone SE for 64-bit testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-06 15:57 PDT by David Quesada
Modified: 2018-08-06 16:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2018-08-06 16:05 PDT, David Quesada 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2018-08-06 15:57:27 PDT 
r234467 changed the default device for testing from iPhone 5s to iPhone SE. webkitdirs.pm should also be updated.
Comment 1 David Quesada 2018-08-06 16:05:22 PDT 
Created attachment 346662 [details]
Patch
Comment 2 Daniel Bates 2018-08-06 16:16:00 PDT 
Comment on attachment 346662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346662&action=review

r=me

> Tools/ChangeLog:7
> +

Please explain that we are making this change to match the corresponding Python change in r234467.
Comment 3 Radar WebKit Bug Importer 2018-08-06 16:49:14 PDT 
<rdar://problem/42986900>
Comment 4 Radar WebKit Bug Importer 2018-08-06 16:49:19 PDT 
<rdar://problem/42986902>
Comment 5 David Quesada 2018-08-06 16:49:52 PDT 
Landed in https://trac.webkit.org/changeset/234634/webkit