Bug 188271 - Reading instructionPointer from PlatformRegisters may fail when using pointer profiling
Summary: Reading instructionPointer from PlatformRegisters may fail when using pointer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-02 12:29 PDT by Saam Barati
Modified: 2018-08-02 17:14 PDT (History)
17 users (show)

See Also:


Attachments
patch (13.31 KB, patch)
2018-08-02 13:05 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-08-02 12:29:15 PDT
...
Comment 1 Saam Barati 2018-08-02 12:29:45 PDT
<rdar://problem/42850884>
Comment 2 Saam Barati 2018-08-02 13:05:42 PDT
Created attachment 346410 [details]
patch
Comment 3 EWS Watchlist 2018-08-02 13:09:48 PDT
Attachment 346410 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tools/SigillCrashAnalyzer.cpp:161:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2018-08-02 16:45:41 PDT
Comment on attachment 346410 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2018-08-02 17:14:17 PDT
Comment on attachment 346410 [details]
patch

Clearing flags on attachment: 346410

Committed r234528: <https://trac.webkit.org/changeset/234528>
Comment 6 WebKit Commit Bot 2018-08-02 17:14:19 PDT
All reviewed patches have been landed.  Closing bug.