Bug 188024 - Secheuristic should be proportional to width, not height.
Summary: Secheuristic should be proportional to width, not height.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-25 15:01 PDT by Jeremy Jones
Modified: 2021-11-01 12:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.36 KB, patch)
2018-07-25 15:09 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2018-07-25 15:13 PDT, Jeremy Jones
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.98 MB, application/zip)
2018-07-26 16:25 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-07-25 15:01:13 PDT
Secheuristic should be proportional to width, not height.
Comment 1 Jeremy Jones 2018-07-25 15:02:59 PDT
rdar://problem/42101780
Comment 2 Jeremy Jones 2018-07-25 15:09:22 PDT
Created attachment 345791 [details]
Patch
Comment 3 EWS Watchlist 2018-07-25 15:10:56 PDT
Attachment 345791 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:68:  Declaration has space between type name and * in m_widthxWeight * pow  [whitespace/declaration] [3]
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:69:  Declaration has space between type name and * in m_heightWeight * pow  [whitespace/declaration] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jeremy Jones 2018-07-25 15:13:11 PDT
Created attachment 345793 [details]
Patch
Comment 5 EWS Watchlist 2018-07-25 15:15:36 PDT
Attachment 345793 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:68:  Declaration has space between type name and * in m_widthWeight * pow  [whitespace/declaration] [3]
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:69:  Declaration has space between type name and * in m_heightWeight * pow  [whitespace/declaration] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EWS Watchlist 2018-07-26 16:25:15 PDT
Comment on attachment 345793 [details]
Patch

Attachment 345793 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8666569

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 7 EWS Watchlist 2018-07-26 16:25:26 PDT
Created attachment 345888 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Alex Christensen 2021-11-01 12:48:58 PDT
Comment on attachment 345793 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.