RESOLVED FIXED 187892
Rename Document::firstPartyForSameSiteCookies() to siteForCookies() 
https://bugs.webkit.org/show_bug.cgi?id=187892
Summary Rename Document::firstPartyForSameSiteCookies() to siteForCookies()
Daniel Bates
Reported 2018-07-22 15:48:51 PDT
Rename Document::firstPartyForSameSiteCookies() to siteForCookies() to match the concept described in the Same-Site RFCs, the latest draft now being <https://httpwg.org/http-extensions/rfc6265bis.html>. Also rename the similarly named setter on Document.
Attachments
Patch (6.25 KB, patch)
2018-07-22 15:52 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.91 MB, application/zip)
2018-07-23 23:31 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-07-22 15:52:42 PDT
Created attachment 345544 [details] Patch
EWS Watchlist
Comment 2 2018-07-23 23:31:46 PDT
Comment on attachment 345544 [details] Patch Attachment 345544 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8634388 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 3 2018-07-23 23:31:58 PDT
Created attachment 345639 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Daniel Bates
Comment 4 2018-07-24 09:27:33 PDT
Comment on attachment 345544 [details] Patch Clearing flags on attachment: 345544 Committed r234148: <https://trac.webkit.org/changeset/234148>
Daniel Bates
Comment 5 2018-07-24 09:27:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-24 09:29:09 PDT
<rdar://problem/42544012>
Note You need to log in before you can comment on or make changes to this bug.