Bug 187660 - Web Inspector: Dark Mode: Layers tab background should be dark
Summary: Web Inspector: Dark Mode: Layers tab background should be dark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-13 14:00 PDT by Nikita Vasilyev
Modified: 2018-07-20 17:30 PDT (History)
4 users (show)

See Also:

Attachments
[Screenshot] Bug (165.95 KB, image/png)
2018-07-13 14:00 PDT, Nikita Vasilyev 		no flags Details
Patch (2.33 KB, patch)
2018-07-20 16:46 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Screenshot] With patch applied (92.23 KB, image/png)
2018-07-20 16:47 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-07-13 14:00:20 PDT 
Created attachment 344978 [details]
[Screenshot] Bug

It's currently white.
Comment 1 Radar WebKit Bug Importer 2018-07-13 14:00:37 PDT 
<rdar://problem/42179616>
Comment 2 Nikita Vasilyev 2018-07-20 16:46:28 PDT 
Created attachment 345487 [details]
Patch
Comment 3 Nikita Vasilyev 2018-07-20 16:47:03 PDT 
Created attachment 345488 [details]
[Screenshot] With patch applied
Comment 4 BJ Burg 2018-07-20 16:51:16 PDT 
Comment on attachment 345487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345487&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:146
> +        const backgroundColor = window.getComputedStyle(document.documentElement).getPropertyValue("--background-color-content").trim();

😬
Comment 5 Nikita Vasilyev 2018-07-20 17:01:29 PDT 
Comment on attachment 345487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345487&action=review

>> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:146
>> +        const backgroundColor = window.getComputedStyle(document.documentElement).getPropertyValue("--background-color-content").trim();
> 
> 😬

It's verbose, but I don't know any better way.

Also, it doesn't work without `trim()` because of the space character in front, e.g. " white".
Comment 6 WebKit Commit Bot 2018-07-20 17:30:17 PDT 
Comment on attachment 345487 [details]
Patch

Clearing flags on attachment: 345487

Committed r234076: <https://trac.webkit.org/changeset/234076>
Comment 7 WebKit Commit Bot 2018-07-20 17:30:18 PDT 
All reviewed patches have been landed.  Closing bug.