RESOLVED FIXED187660
Web Inspector: Dark Mode: Layers tab background should be dark 
https://bugs.webkit.org/show_bug.cgi?id=187660
Summary Web Inspector: Dark Mode: Layers tab background should be dark
Nikita Vasilyev
Reported 2018-07-13 14:00:20 PDT
Created attachment 344978 [details] [Screenshot] Bug It's currently white.
Attachments
[Screenshot] Bug (165.95 KB, image/png)
2018-07-13 14:00 PDT, Nikita Vasilyev 		no flags
Details
Patch (2.33 KB, patch)
2018-07-20 16:46 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Screenshot] With patch applied (92.23 KB, image/png)
2018-07-20 16:47 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-13 14:00:37 PDT
<rdar://problem/42179616>
Nikita Vasilyev
Comment 2 2018-07-20 16:46:28 PDT
Created attachment 345487 [details] Patch
Nikita Vasilyev
Comment 3 2018-07-20 16:47:03 PDT
Created attachment 345488 [details] [Screenshot] With patch applied
Blaze Burg
Comment 4 2018-07-20 16:51:16 PDT
Comment on attachment 345487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345487&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:146 > + const backgroundColor = window.getComputedStyle(document.documentElement).getPropertyValue("--background-color-content").trim(); 😬
Nikita Vasilyev
Comment 5 2018-07-20 17:01:29 PDT
Comment on attachment 345487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345487&action=review >> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:146 >> + const backgroundColor = window.getComputedStyle(document.documentElement).getPropertyValue("--background-color-content").trim(); > > 😬 It's verbose, but I don't know any better way. Also, it doesn't work without `trim()` because of the space character in front, e.g. " white".
WebKit Commit Bot
Comment 6 2018-07-20 17:30:17 PDT
Comment on attachment 345487 [details] Patch Clearing flags on attachment: 345487 Committed r234076: <https://trac.webkit.org/changeset/234076>
WebKit Commit Bot
Comment 7 2018-07-20 17:30:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.