Bug 187638 - [GStreamer] Use smart pointers for GstByteReader
Summary: [GStreamer] Use smart pointers for GstByteReader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-13 03:37 PDT by Charlie Turner
Modified: 2018-07-13 11:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2018-07-13 03:39 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2018-07-13 05:47 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2018-07-13 09:09 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2018-07-13 10:40 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (4.26 KB, patch)
2018-07-13 10:41 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2018-07-13 03:37:37 PDT 
[GStreamer] Use smart pointers for GstByteReader
Comment 1 Charlie Turner 2018-07-13 03:39:45 PDT 
Created attachment 344934 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2018-07-13 04:34:31 PDT 
Comment on attachment 344934 [details]
Patch

I didn't set cq+ because I think you need to rebase
Comment 3 Charlie Turner 2018-07-13 05:47:01 PDT 
Created attachment 344937 [details]
Patch
Comment 4 Charlie Turner 2018-07-13 09:09:46 PDT 
Created attachment 344949 [details]
Patch
Comment 5 Charlie Turner 2018-07-13 10:40:41 PDT 
Created attachment 344953 [details]
Patch
Comment 6 Charlie Turner 2018-07-13 10:41:44 PDT 
Created attachment 344954 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-07-13 11:20:10 PDT 
Comment on attachment 344954 [details]
Patch for landing

Clearing flags on attachment: 344954

Committed r233805: <https://trac.webkit.org/changeset/233805>
Comment 8 WebKit Commit Bot 2018-07-13 11:20:12 PDT 
All reviewed patches have been landed.  Closing bug.