Bug 187410 - [Web Animations] A number of tests report an incorrect computed offset
Summary: [Web Animations] A number of tests report an incorrect computed offset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 13:44 PDT by Antoine Quint
Modified: 2018-07-08 21:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (17.68 KB, patch)
2018-07-06 13:48 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-07-06 13:44:43 PDT
[Web Animations] A number of tests report an incorrect computed offset
Comment 1 Radar WebKit Bug Importer 2018-07-06 13:45:15 PDT
<rdar://problem/41905790>
Comment 2 Antoine Quint 2018-07-06 13:48:30 PDT
Created attachment 344450 [details]
Patch
Comment 3 Dean Jackson 2018-07-08 20:43:29 PDT
Comment on attachment 344450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344450&action=review

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:-144
> -        if (indexOfLastKeyframeWithNonNullOffset == i - 1)
> -            continue;

I guess you could have just made this:
if (indexOfLastKeyframeWithNonNullOffset == i - 1) {
  indexOfLastKeyframeWithNonNullOffset = i;
  continue;
}
Comment 4 WebKit Commit Bot 2018-07-08 21:10:47 PDT
Comment on attachment 344450 [details]
Patch

Clearing flags on attachment: 344450

Committed r233632: <https://trac.webkit.org/changeset/233632>
Comment 5 WebKit Commit Bot 2018-07-08 21:10:49 PDT
All reviewed patches have been landed.  Closing bug.