RESOLVED FIXED187195
teach bisect-builds to fetch supported platforms from the rest api 
https://bugs.webkit.org/show_bug.cgi?id=187195
Summary teach bisect-builds to fetch supported platforms from the rest api
Lucas Forschler
Reported 2018-06-29 14:43:28 PDT
We now have an api endpoint to get a list of available builds. teach bisect-builds to use it.
Attachments
patch for review (5.47 KB, patch)
2018-06-29 15:19 PDT, Lucas Forschler 		aakash_jain: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-29 14:49:37 PDT
<rdar://problem/41653798>
Lucas Forschler
Comment 2 2018-06-29 15:19:17 PDT
Created attachment 343951 [details] patch for review
Aakash Jain
Comment 3 2018-06-29 15:39:35 PDT
Comment on attachment 343951 [details] patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=343951&action=review > Tools/Scripts/bisect-builds:202 > + r = urllib2.urlopen(platform_url) You can consider making a separate method to fetching data from url, e.g.: fetch_data_from_url(url). That method can be used in fetch_revision_list() as well. But that can be done later on in a separate patch as well. > Tools/Scripts/bisect-builds:206 > + for platform in data['Items']: Is data guaranteed to have 'Items' key. what if data is empty? Do we want to crash here? You might consider using data.get('Items')
Lucas Forschler
Comment 4 2018-06-29 15:52:13 PDT
Committed revision 233373.
Note You need to log in before you can comment on or make changes to this bug.